Add CRDs printcolumns #353
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #353 +/- ##
==========================================
- Coverage 65.19% 64.98% -0.22%
==========================================
Files 35 35
Lines 3795 3795
==========================================
- Hits 2474 2466 -8
- Misses 1127 1133 +6
- Partials 194 196 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
|
|
looking good! |
|
We need to check this in openshift and see how it integrates. |
|
Synced with @grzpiotrowski on a call and we had a look at OpenShift install - looks like we can still see all the fields with either a
|
| @@ -200,6 +200,10 @@ func (s *AuthPolicyStatus) Equals(other *AuthPolicyStatus, logger logr.Logger) b | |||
| // +kubebuilder:object:root=true | |||
| // +kubebuilder:subresource:status | |||
| // +kubebuilder:metadata:labels="gateway.networking.k8s.io/policy=direct" | |||
| // +kubebuilder:printcolumn:name="Status",type=string,JSONPath=`.status.conditions[0].reason`,description="AuthPolicy Status",priority=2 | |||
There was a problem hiding this comment.
This relies on the fact the we currently only set one condition per status stanza, which is fine for now.
Soon, it will have to differentiate Accepted and Enforced. E.g.:
// +kubebuilder:printcolumn:name="Accepted",type=string,JSONPath=`.status.conditions[?(@.type=="Accepted")].status`,description="AuthPolicy Accepted",priority=2
// +kubebuilder:printcolumn:name="Enforced",type=string,JSONPath=`.status.conditions[?(@.type=="Enforced")].status`,description="AuthPolicy Enforced",priority=2See https://docs.kuadrant.io/architecture/rfcs/0004-policy-status.
This PR adds new columns with status and target refs information to kubectl get output with -o wide option.
Examples of the new output:
For RateLimitPolicy:
For AuthPolicy:
For Kuadrant:
Verification
Verification trough one of the guides.
Closes #345